training

Update: Vendor "TDS Applies On" (PO / WO / Both) — reviewed, fixed and tested (#3378)¶

Branch: feature/shreya/3378-vendor-tds-applicable-dropdown-ui

The branch was checked against the Vendor Management UI Integration Guide (TDS fields). The backend change is live on dev: the vendor API now returns tdsAppliesOn, tdsPercentPo and tdsPercentWo, and the old single tdsPercent is gone.

What the UI does now¶

Where: Vendor form → Finance Settings. This is in both the Vendor page form (Add / Edit Vendor) and the quick "add vendor" drawer used from Purchase Order / Work Order.

• With TDS Applicable off, no TDS fields are shown and nothing TDS-related is saved.
• With TDS Applicable on, a TDS Applies On \* dropdown appears with: Purchase Orders (PO) / Work Orders (WO) / Both (PO & WO).
• Rate fields show by selection:
  • PO → "TDS % on Purchase Orders \*" — hint "Deducted from PO advances and Vendor Bills"
  • WO → "TDS % on Work Orders \*" — hint "Deducted from WO advances and Service Bills"
  • Both → both fields
• Validation:
  • Applies On empty → "Select where TDS applies: PO, WO or Both"
  • Rate empty, 0 or above 100 → "Enter a rate greater than 0 and at most 100"
• Save sends only the rate that applies; the other one is sent as null. Switching TDS off sends tdsAppliesOn and both rates as null.
• Edit pre-fills Applies On and the saved rates.
• Vendor detail shows, for example, "Yes · Both (PO & WO) · PO 0.1% · WO 2%". A missing rate shows "rate not set" instead of "null%".

Fixes made on top of the branch¶

1. In the quick-add drawer, typing a PO rate cleared the WO error instead of the PO one, so the red PO error stayed until the next save. Fixed.
2. Vendor detail showed "PO: null% · WO: null%" for vendors whose rates are empty. Fixed.
3. Unused imports removed; the lint warnings are back to the production level.

Testing on dev (tenant bbm): 15/15 passed¶

• TDS off: no TDS fields. TDS on: "TDS Applies On \*" with the 3 options and no rate field yet.
• Save with Applies On empty shows "Select where TDS applies: PO, WO or Both".
• PO shows only the PO rate field, WO only the WO field, and Both shows both, each with the right hint.
• Both with the PO rate empty, and a rate of 150, both show "Enter a rate greater than 0 and at most 100". Typing a valid rate clears the error.
• Create payload: {"tdsApplicable":true,"tdsAppliesOn":"BOTH","tdsPercentPo":0.1,"tdsPercentWo":2} — no old tdsPercent.
• Edit vendor "QA_PO_WO_Testing" (Both 2% / 2%):
  • the form is pre-filled;
  • changing to WO only sends tdsPercentPo: null, tdsPercentWo: 2;
  • switching TDS off sends tdsApplicable: false with Applies On and both rates null.
• Vendor detail: "Apex Engineering Consultants" → "Yes · Both (PO & WO) · PO 0.01% · WO 0.01%"; "Naren" → "Yes · Both (PO & WO) · PO rate not set · WO rate not set".
• Record Payment / advances, Vendor Bills and Service Bills need no change: they take the TDS rate per order / bill from the API. On dev, the eligible orders return the rate for both PO and WO orders.

Note: in this test the save requests were captured to check the payload and not sent to the server, so no vendor data was changed on dev. Please do one real save for each of PO, WO and Both and check the vendor afterwards.

Points for QA¶

1. On dev, vendors Naren and shree cables have TDS = Both but no rates saved. Editing them asks for the rates before saving, which is expected.
2. Please also check that advances and bills for a vendor with different PO and WO rates (e.g. PO 1%, WO 2%) deduct the right rate for each order type.

Screenshots are attached.